Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ITaxProvider - Do not recalculate tax for docline when it is processed

Description

MOrderLine.afterSave() always calls ITaxProvider.recalculateTax() even when processing shipments/invoices (due to changes in reserved/delivered/invoiced fields). Althought being simple to work around this behavior (checking isProcessed in recalculateTax() and just returning), it not seems to be consistent this call to the method.

What about adding !isProcessed() before trying to recalculte taxes?

Attached is suggestion patch for MOrderLine/MInvoiceLine/MRMALine

Environment

None

Attachments

1

Activity

Show:

MarcoL August 22, 2020 at 11:52 AM

Not clear whatis the problem . Please Alan show example to reproduce

thanks

MarcoL August 22, 2020 at 11:48 AM

triaging Marco Longo

Alan Lescano March 8, 2014 at 4:36 PM
Edited

The patch resolve when processing shipments/invoices, but doesn't resolve the call to recalculateTax() when preparing order and qty of line was changed - due to changing reserved qty field.

Details

Assignee

Reporter

Labels

Priority

Created March 8, 2014 at 2:29 PM
Updated August 22, 2020 at 1:13 PM